Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add keithmattix/Microsoft to PSWG #1064

Merged
merged 1 commit into from
May 22, 2023
Merged

Add keithmattix/Microsoft to PSWG #1064

merged 1 commit into from
May 22, 2023

Conversation

howardjohn
Copy link
Member

@howardjohn howardjohn commented May 22, 2023 •
edited
Loading

Process is for TOC to approve. We have approval from 3 (counting myself, in a private email thread), so considering this 'approved'

cc @keithmattix

@istio-testing
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@istio-testing istio-testing added do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 22, 2023
@howardjohn howardjohn marked this pull request as ready for review May 22, 2023 17:04
@howardjohn howardjohn requested a review from a team as a code owner May 22, 2023 17:04
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label May 22, 2023
@howardjohn howardjohn changed the title Add keithmattix to PSWG Add keithmattix/Microsoft to PSWG May 22, 2023
craigbox
craigbox approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@craigbox craigbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@istio-testing istio-testing merged commit b14bfca into istio:master May 22, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@craigbox craigbox craigbox approved these changes

@kfaseela kfaseela kfaseela approved these changes

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@howardjohn @istio-testing @craigbox @kfaseela