Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: bad json format of stats config #3456

Merged
merged 1 commit into from
Aug 13, 2021
Merged

fix: bad json format of stats config #3456

merged 1 commit into from
Aug 13, 2021

Conversation

Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented Aug 13, 2021

What this PR does / why we need it:

fix: bad JSON format

Special notes for your reviewer:

cc @lizan

fix: bad JSON format
@Xunzhuo Xunzhuo requested a review from a team as a code owner August 13, 2021 07:42
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 13, 2021
@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Aug 13, 2021
@istio-testing
Copy link
Collaborator

Hi @Xunzhuo. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bianpengyuan
Copy link
Contributor

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Aug 13, 2021
@istio-testing istio-testing merged commit 5139df7 into istio:master Aug 13, 2021
@Xunzhuo Xunzhuo changed the title Fix bad JSON format fix: bad json format of stats config Aug 16, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants