Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

dependencies: update to tonic 0.12 #1170

Merged
merged 5 commits into from
Jul 9, 2024
Merged

dependencies: update to tonic 0.12 #1170

merged 5 commits into from
Jul 9, 2024

Conversation

howardjohn
Copy link
Member

Pending hyperium/tonic#1740. DNM until its
released.

This lets us drop a few shims

@howardjohn howardjohn added the release-notes-none Indicates a PR that does not require release notes. label Jun 21, 2024
@istio-testing
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@istio-testing istio-testing added do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 21, 2024
howardjohn added 2 commits July 8, 2024 09:56
@howardjohn
dependencies: update to tonic 0.12
21a7283 
Pending hyperium/tonic#1740. DNM until its
released.

This lets us drop a few shims
@howardjohn
Use official
efd171b
@howardjohn howardjohn marked this pull request as ready for review July 8, 2024 18:12
@howardjohn howardjohn requested a review from a team as a code owner July 8, 2024 18:12
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jul 8, 2024
@howardjohn
Copy link
Member Author

/retest

bleggett
bleggett approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@bleggett bleggett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shoulda gotten to this one sooner, apologies. LGTM

@istio-testing istio-testing merged commit 88320b0 into istio:master Jul 9, 2024
3 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bleggett bleggett bleggett approved these changes

Assignees

@bleggett bleggett

Labels
release-notes-none Indicates a PR that does not require release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@howardjohn @istio-testing @bleggett