If a detailed error message is available, do not overwrite #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When verification of ACs fails, the prior behavior is to always have this message: ``` Cannot verify AC signature! ``` This can be difficult to debug as there's no indication of whether its a problem with the proxy itself or with the host configuration. This patch appends the underlying error message if one was provided. For example, ``` Cannot verify AC signature! Underlying error: Certificate verification \ failed for certificate '/CN=voms.example.com': certificate has expired. ``` (newlines added for readability)
|
Thanks for the patch. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When verification of ACs fails, the prior behavior is to always have this message:
This can be difficult to debug as there's no indication of whether its a problem with the proxy itself or with the host configuration.
This patch appends the underlying error message if one was provided. For example,
(newlines added for readability)