-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
'Hidden' gamemod #115
'Hidden' gamemod #115
Conversation
Awesome, thanks so much! I'm glad the mods are finally finished now (well, the basic ones, at least) :D! This was my first time actually trying the mod in osu!, so let me know if I'm mistaken about anything. That said, here are differences I noticed:
Lastly, some questions about
|
I re-enabled the slider follow circle and disabled the spinner circle. The |
Just tried Ievan Pollka, apparently the spinner completion meter still appears |
Great, thanks for the fast reply. I'll go ahead and merge this now, but feel free to keep commenting here and/or submit another pull request if you want to add anything. The spinner meter is still present, but the spinner approach circle should also be hidden -- sorry I didn't catch that earlier. I'll change that one myself. EDIT: The slider ball is present too. My bad. x.x |
Wow, I'm really sorry, I provided a lot of wrong information... it's not the spinner circle that disappears, but only the spinner approach circle. I totally forgot what my skin looked like. I'll fix that as well. |
- Hide the spinner approach circle instead of the spinner circle. - Show the slider ball. Signed-off-by: Jeffrey Han <itdelatrisu@gmail.com>
This introduces more accurate timing formulas associated with the "Hidden" mod (previously, in #115, these values were hardcoded). The values seem somewhat close to the values in osu!, but were not extensively tested. Also set an upper bound on the fade in time for hit objects proportional to the approach time, or else the timing values in the "Hidden" mod would be too inconsistent. Signed-off-by: Jeffrey Han <itdelatrisu@gmail.com>
Enables the 'hidden' game-mod and changes circles and sliders accordingly.