Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

'Hidden' gamemod #115

Merged
merged 4 commits into from
Aug 8, 2015
Merged

'Hidden' gamemod #115

merged 4 commits into from
Aug 8, 2015

Conversation

mad-s
Copy link
Contributor

@mad-s mad-s commented Aug 8, 2015

Enables the 'hidden' game-mod and changes circles and sliders accordingly.

@itdelatrisu
Copy link
Owner

Awesome, thanks so much! I'm glad the mods are finally finished now (well, the basic ones, at least) :D!

This was my first time actually trying the mod in osu!, so let me know if I'm mistaken about anything. That said, here are differences I noticed:

  • The slider follow circle should still appear with the mod enabled.
  • The SPINNER_CIRCLE element should not appear with the mod enabled.

Lastly, some questions about decayTime:

  • Is 800 a value you estimated, or is it the actual value? It seems pretty similar to osu!, but if it's not an exact number, just add a TODO to make that clear; otherwise, what's your source?
  • Does the value ever change (with difficulty settings, etc.)? If not, it can just be a public static constant, and doesn't need an instance accessor.

@mad-s
Copy link
Contributor Author

mad-s commented Aug 8, 2015

I re-enabled the slider follow circle and disabled the spinner circle. The decayTime value is just an estimate. My only source of information are videos (I run Linux) and they are not very consistent. Maybe someone can measure the decay time.
Does the spinning meter appear in hidden mode?

@abalabahaha
Copy link

Just tried Ievan Pollka, apparently the spinner completion meter still appears

@itdelatrisu
Copy link
Owner

Great, thanks for the fast reply. I'll go ahead and merge this now, but feel free to keep commenting here and/or submit another pull request if you want to add anything.

The spinner meter is still present, but the spinner approach circle should also be hidden -- sorry I didn't catch that earlier. I'll change that one myself.

EDIT: The slider ball is present too. My bad. x.x

itdelatrisu added a commit that referenced this pull request Aug 8, 2015
@itdelatrisu itdelatrisu merged commit 262fa9d into itdelatrisu:master Aug 8, 2015
@itdelatrisu
Copy link
Owner

Wow, I'm really sorry, I provided a lot of wrong information... it's not the spinner circle that disappears, but only the spinner approach circle. I totally forgot what my skin looked like. I'll fix that as well.

itdelatrisu added a commit that referenced this pull request Aug 9, 2015
- Hide the spinner approach circle instead of the spinner circle.
- Show the slider ball.

Signed-off-by: Jeffrey Han <itdelatrisu@gmail.com>
itdelatrisu added a commit that referenced this pull request Aug 29, 2015
This introduces more accurate timing formulas associated with the "Hidden" mod (previously, in #115, these values were hardcoded).  The values seem somewhat close to the values in osu!, but were not extensively tested.

Also set an upper bound on the fade in time for hit objects proportional to the approach time, or else the timing values in the "Hidden" mod would be too inconsistent.

Signed-off-by: Jeffrey Han <itdelatrisu@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants