Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rewrote shaders for GLSL 110 (openGL2.0). #124

Merged
merged 1 commit into from
Aug 25, 2015

Conversation

Szunti
Copy link
Contributor

@Szunti Szunti commented Aug 24, 2015

For poor guys with eg. old intel gma mobile gpus.

@itdelatrisu
Copy link
Owner

Thanks for the contribution! Just running a quick search through itdelatrisu.opsu.render, though, there are these GL30 calls in CurveRenderState.java:

  • GL30.glBindFragDataLocation(program, 0, "out_colour");
  • GL30.glGenerateMipmap(GL11.GL_TEXTURE_1D);

@Szunti Szunti force-pushed the opengl2-shaders branch 2 times, most recently from 696eb0f to a3625ed Compare August 24, 2015 19:45
@Szunti
Copy link
Contributor Author

Szunti commented Aug 24, 2015

Does it look better now?

out_colour variable was deleted in the GLSL110 version, so I deleted the glBindFragDataLocation call.
GenerateMipmapEXT is part of the EXTFramebufferobject extension, so I changed to that version.

@Szunti
Copy link
Contributor Author

Szunti commented Aug 24, 2015

Actually I did care about checking the GL2+ things except for GenerateMipmap, where I thought it's not a tragedy if that fails.

The other line sneak in beacuse I edited the files before f0b87c9 and rebased the commit.

@itdelatrisu
Copy link
Owner

Other than removing the unused org.lwjgl.opengl.GL30 import, it looks fine to me, but I'll leave this open for a day or so in case anyone else has comments (since I still know nothing about OpenGL :P). Thanks again!

itdelatrisu added a commit that referenced this pull request Aug 25, 2015
Rewrote shaders for GLSL 110 (openGL2.0).
@itdelatrisu itdelatrisu merged commit 4b68ceb into itdelatrisu:master Aug 25, 2015
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants