Synchronize notifications list access #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpenguinltg
force-pushed
the
synchronized-notifications
branch
from
433734f to
a63dedb
Compare
Prevents a ConcurrentModificationException when a notification is added while the list is iterated over. This approach is recommended in the docs: https://docs.oracle.com/javase/7/docs/api/java/util/Collections.html#synchronizedList%28java.util.List%29
tpenguinltg
force-pushed
the
synchronized-notifications
branch
from
a63dedb to
1f6c9df
Compare
Clearing the notifications is actually the end part of the larger operation done by the preceding for loop, so it should be in the same synchronized block. Doing this prevents a race condition where a notification is added, but is then immediately removed without being shown.
|
Thanks, my bad. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #253
This approach is recommended in the docs:
https://docs.oracle.com/javase/7/docs/api/java/util/Collections.html#synchronizedList%28java.util.List%29