-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Optionmenu navigation #298
Optionmenu navigation #298
Conversation
9ba0117
to
91dddc3
Compare
This looks amazing, thanks so much! Only a few comments:
|
Nice work! Like @itdelatrisu mentioned, I would suggest widening the overlay because the text in long lines get cut off (e.g. the option under Language) and short sliders like the "Track checkpoint" slider is also almost unusable. |
…set width to 0.5x total size on non-widescreen aspect ratios
Done & done! The width was a silly mistake; it was 0.42x the width but the width of the nav bar was subtracted from it... I fixed that and made it 0.4x width for widescreen, and 0.5x for 4:3 resolutions (as in osu!). |
Thanks again! :) |
(introduced in #298) Signed-off-by: Jeffrey Han <itdelatrisu@gmail.com>
Sidebar navigation for the option menu, as described in #283
Some differences between this and osu!:
Notes:
MainMenu
&SongMenu
for animations alpha. The option menu fades quicker than the navigation elements in the menu, so I had to adjust some things. It's now a bit messier as the fading animation is not handled in theOptionsOverlay
class, but on other places.I made some (shit) icons based on the ones in osu!, if anyone is experienced in making such images, please make better ones ^^Used font-awesomeExtra: Search filter won't accept new characters when there would be no results + added the little animation that osu! does when that happens.
I didn't forget to commit the added resources for once, yey!
EDIT: hold on, someone suggested to use font-awesome for the icons, I'll probably delete the commit with my shitty iconsdone