Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Avoid code duplication in FFmpeg framerate parsing #363

Closed
wants to merge 1 commit into from

Conversation

tpenguinltg
Copy link
Contributor

In case you don't get to it first. (Related: 0b36328, #362)

(k?) is used instead of (k)? so that the region will always match, even if it's empty.

(k?) is used instead of (k)? so that the region will always match, even
if it's empty.
@tpenguinltg
Copy link
Contributor Author

Closed by 6449b73

@itdelatrisu
Copy link
Owner

Oops, didn't see this in time: 6449b73
Anyhow, you can't use == on strings. :P

@tpenguinltg
Copy link
Contributor Author

Oh, you're right. I've been spoiled by JavaScript. I guess it just evaluated to false and didn't do the multiplication.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants