Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

proc: disconnect parent signal handlers in process.spawn() #60

Closed
pmrowla opened this issue Jun 9, 2022 · 2 comments · Fixed by #64
Closed

proc: disconnect parent signal handlers in process.spawn() #60

pmrowla opened this issue Jun 9, 2022 · 2 comments · Fixed by #64
Assignees
@pmrowla
Labels
bug Something isn't working

Comments

@pmrowla
Copy link
Contributor

pmrowla commented Jun 9, 2022

SIGINT should not be forwarded to the daemon (child) process
@pmrowla pmrowla self-assigned this Jun 9, 2022
@pmrowla pmrowla added this to DVC Jun 9, 2022
@pmrowla pmrowla moved this to Backlog in DVC Jun 9, 2022
@pmrowla pmrowla moved this from Backlog to In Progress in DVC Jun 9, 2022
@dberenbaum
Copy link

dberenbaum commented Jun 9, 2022 •
edited
Loading

Does this happen now? In case this is related to iterative/dvc#7860 (comment), interrupting the logs right now does not interrupt the experiment AFAIK.

Edit: Never mind, I hadn't read your latest comments in that PR. Looks like this isn't directly related.

@pmrowla
Copy link
Contributor Author

pmrowla commented Jun 10, 2022

@dberenbaum yeah this isn't directly related to the logs command. This bug shows up when using run --temp and ctrl-c'ing (and the bug is that it generates an extra/unexpected error traceback in the UI)

@pmrowla pmrowla mentioned this issue Jun 13, 2022
Merged
@pmrowla pmrowla added the bug Something isn't working label Jun 13, 2022
Repository owner moved this from In Progress to Done in DVC Jun 13, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@pmrowla pmrowla

Labels
bug Something isn't working
Projects
No open projects
DVC
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

proc: set pgrp in spawned daemon processes pmrowla/dvc-task
2 participants
@pmrowla @dberenbaum