Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

proc: set pgrp in spawned daemon processes #64

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

pmrowla
Copy link
Contributor

@pmrowla pmrowla commented Jun 13, 2022

Sets pgrp in spawned proc so signals are not forwarded from the original parent. Signal handlers are still inherited (so caller is responsible for configuring SIG_IGN/SIG_DFL/custom handlers as desired)

Fixes #60

@pmrowla pmrowla self-assigned this Jun 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2022

Codecov Report

Merging #64 (180949c) into main (708e0a9) will increase coverage by 0.09%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   86.49%   86.59%   +0.09%     
==========================================
  Files          19       19              
  Lines         711      716       +5     
  Branches       98      100       +2     
==========================================
+ Hits          615      620       +5     
- Misses         76       78       +2     
+ Partials       20       18       -2     
Impacted Files Coverage Δ
src/dvc_task/proc/process.py 84.54% <33.33%> (-2.13%) ⬇️
src/dvc_task/worker/temporary.py 87.93% <0.00%> (+5.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 708e0a9...180949c. Read the comment docs.

@pmrowla pmrowla merged commit d132caa into iterative:main Jun 13, 2022
@pmrowla pmrowla deleted the 60-proc-signal branch June 13, 2022 09:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proc: disconnect parent signal handlers in process.spawn()
2 participants