Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

worker: support auto-running fsapp.clean on shutdown #110

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

pmrowla
Copy link
Contributor

@pmrowla pmrowla commented Feb 28, 2023

No description provided.

@pmrowla pmrowla self-assigned this Feb 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2023

Codecov Report

Base: 74.18% // Head: 79.33% // Increases project coverage by +5.14% 🎉

Coverage data is based on head (903ad7c) compared to base (ecfd4a9).
Patch coverage: 57.14% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
+ Coverage   74.18%   79.33%   +5.14%     
==========================================
  Files          21       21              
  Lines         984      987       +3     
  Branches      153      154       +1     
==========================================
+ Hits          730      783      +53     
+ Misses        219      180      -39     
+ Partials       35       24      -11     
Impacted Files Coverage Δ
src/dvc_task/worker/temporary.py 79.68% <50.00%> (+2.63%) ⬆️
tests/worker/test_temporary.py 100.00% <100.00%> (+3.03%) ⬆️
src/dvc_task/proc/exceptions.py 93.33% <0.00%> (+6.66%) ⬆️
src/dvc_task/utils.py 46.03% <0.00%> (+7.93%) ⬆️
src/dvc_task/contrib/kombu_filesystem.py 39.28% <0.00%> (+8.33%) ⬆️
src/dvc_task/proc/manager.py 80.99% <0.00%> (+9.91%) ⬆️
tests/proc/test_manager.py 100.00% <0.00%> (+15.73%) ⬆️
tests/test_utils.py 100.00% <0.00%> (+28.57%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pmrowla pmrowla merged commit 358a100 into iterative:main Feb 28, 2023
@pmrowla pmrowla deleted the worker-autoclean branch February 28, 2023 05:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants