Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fsapp: remove pidbox replies on clean #112

Merged
merged 2 commits into from
Apr 27, 2023
Merged

Conversation

pmrowla
Copy link
Contributor

@pmrowla pmrowla commented Apr 27, 2023

When workers exit they will end up leaving filesystem broker control messages that never expire and will never be ack'd in the future, we should just purge them on clean

@pmrowla pmrowla self-assigned this Apr 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2023

Codecov Report

Patch coverage: 52.63% and project coverage change: -5.95 ⚠️

Comparison is base (358a100) 79.12% compared to head (b547384) 73.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
- Coverage   79.12%   73.18%   -5.95%     
==========================================
  Files          21       21              
  Lines         987     1007      +20     
  Branches      154      154              
==========================================
- Hits          781      737      -44     
- Misses        179      235      +56     
- Partials       27       35       +8     
Impacted Files Coverage Δ
src/dvc_task/app/filesystem.py 79.03% <28.57%> (-10.69%) ⬇️
src/dvc_task/worker/temporary.py 79.10% <81.25%> (-0.59%) ⬇️
tests/worker/test_temporary.py 93.93% <100.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pmrowla pmrowla merged commit f23893b into iterative:main Apr 27, 2023
@pmrowla pmrowla deleted the clean-pidbox branch April 27, 2023 09:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants