Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix #10593 -- add --keep option for dvc experiments remove #10633

Merged
merged 25 commits into from
Nov 30, 2024
Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
725b02d
Add keep_selected parameter, and corresponding code to keep only the …
rmic Nov 23, 2024
e47cc72
test keep_selected_by_name
rmic Nov 23, 2024
df6a7ed
test keep_selected_by_rev
rmic Nov 23, 2024
df2a1ee
test keep_selected multiple, by name
rmic Nov 23, 2024
4f32f20
test keep all by name
rmic Nov 23, 2024
f913ffb
test keep by rev, with num=2
rmic Nov 23, 2024
c3a46da
added option to cli
rmic Nov 23, 2024
4e84b2d
refactoring to meet pr needs
rmic Nov 23, 2024
7f050ed
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 23, 2024
36a0e2b
fixed test_experiments to add keep_selected=False to remove tests
rmic Nov 23, 2024
87abac1
rename parameter to match cli option
rmic Nov 24, 2024
ca279b9
follow the normal path, then invert the selection before removing
rmic Nov 24, 2024
a903507
fixed tests for list ordering + fixed test with non existent name, it…
rmic Nov 24, 2024
cb43ca3
changed cli option comment
rmic Nov 24, 2024
3184250
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 24, 2024
dea54cb
fixed typing issue
rmic Nov 24, 2024
421c3f0
updated parameter name
rmic Nov 24, 2024
0a76842
removed handling queued experiments (since --queue would remove them …
rmic Nov 26, 2024
783b67a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 26, 2024
b83108a
code simplification, added __eq__ and __hash__ to be able to compare …
rmic Nov 27, 2024
61fda46
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 27, 2024
c6c67b9
fixed linting issues
rmic Nov 28, 2024
9397e83
- --keep and --queue together raise an InvalidArgumentError
rmic Nov 29, 2024
9365b8a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 29, 2024
fe5c5d7
re-run gh tests. Some tests which did not involve my changes started …
rmic Nov 29, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
changed cli option comment
  • Loading branch information
rmic authored and skshetry committed Nov 29, 2024
commit cb43ca36d846f5f9e1dbb3ac339f44353b297519
1 change: 0 additions & 1 deletion dvc/commands/experiments/__init__.py
Original file line number Diff line number Diff line change
@@ -64,7 +64,6 @@ def add_keep_selection_flag(experiments_subcmd_parser):
action="store_true",
default=False,
help="Keep the selected experiments instead of removing them "
"(use it with `--rev`' and `--num` or with experiment names).",
)