Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(example-get-started): add GitLab CI to publish reports #283

Merged
merged 1 commit into from
May 6, 2024

Conversation

shcheklein
Copy link
Member

@shcheklein shcheklein requested a review from dberenbaum May 4, 2024 18:24
@shcheklein shcheklein self-assigned this May 4, 2024
@shcheklein shcheklein added the A: example-get-started General DVC examples label May 4, 2024
Copy link

@dberenbaum dberenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since I don't think there are any blockers, but I have a couple questions:

  1. Should we add a mention to the readme?
  2. Not sure I follow why some files get included in code.zip and others don't.

@shcheklein
Copy link
Member Author

Should we add a mention to the readme?

I was thinking about this, but that means ideally we automate this as well. So, let's postpone this for now.

Not sure I follow why some files get included in code.zip and others don't.

some legacy cleanup, no changes in terms of including older files.

Thanks @dberenbaum for the review.

@shcheklein shcheklein merged commit 1ab0473 into master May 6, 2024
1 check passed
@shcheklein shcheklein deleted the example-get-started/add-gitlab-ci branch May 6, 2024 18:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A: example-get-started General DVC examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants