Skip to content
This repository was archived by the owner on Sep 13, 2023. It is now read-only.

mlem deploy create should re-deploy if model changed #236

Closed
aguschin opened this issue May 7, 2022 · 0 comments · Fixed by #255
Closed

mlem deploy create should re-deploy if model changed #236

aguschin opened this issue May 7, 2022 · 0 comments · Fixed by #255
Labels
deploy Related to model deployment enhancement New feature or request

Comments

@aguschin
Copy link
Contributor

aguschin commented May 7, 2022

Saving a model from #235, then deploying it to heroku makes error (as numpy is not installed in heroku container):

$ mlem deploy status myservice
crashed

If you add some lines to dog-bark-translator.mlem:

requirements:
- module: emoji
  version: 1.7.0
- module: numpy
  version: 1.22.3

and try to redeploy:

$ mlem deploy create myservice
⏳️ Loading deployment from myservice.mlem
🔗 Loading link to file://staging.mlem
🔗 Loading link to file://dog-bark-translator.mlem
💾 Updating deployment at myservice.mlem
✅  Service mlem-quick-start is up. You can check it out at https://mlem-quick-start.herokuapp.com/

Nothing changes, e.g. https://mlem-quick-start.herokuapp.com/ still doesn't work and as I can see from heroku logs, model wasn't redeployed.

It could be default behavior to redeploy if something changed (I would prefer this).
It could also be --force option, but I don't see it in mlem deploy create myservice -h.
Even if we use default to redeploy, --force still may be useful.

@aguschin aguschin added enhancement New feature or request deploy Related to model deployment labels May 7, 2022
@aguschin aguschin added this to the Release Critical milestone May 11, 2022
mike0sv added a commit that referenced this issue May 18, 2022
closes #236
closes #238
aguschin pushed a commit that referenced this issue May 19, 2022
* redeploy models
closes #236
closes #238

* fix entrypoint
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
deploy Related to model deployment enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant