Skip to content
This repository was archived by the owner on Sep 13, 2023. It is now read-only.

Inconsistency in options image_name vs image.name #545

Closed
aguschin opened this issue Dec 27, 2022 · 2 comments
Closed

Inconsistency in options image_name vs image.name #545

aguschin opened this issue Dec 27, 2022 · 2 comments
Labels
bug Something isn't working cli MLEM command-line interface p1-high High priority ux Things that matter for user experience

Comments

@aguschin
Copy link
Contributor

Note the difference:

$ mlem deploy run docker_container docker_container.mlem -m lyrics2emoji --image_name mlem-lyrics2emoji
$ mlem build docker -m lyrics2emoji --image.name mlem-lyrics2emoji
@aguschin aguschin added bug Something isn't working ux Things that matter for user experience cli MLEM command-line interface p1-high High priority labels Dec 27, 2022
@mike0sv
Copy link
Contributor

mike0sv commented Jan 19, 2023

The difference if because deploy has a separate field image_name for this option and build has image field of type DockerImage that has nested name field. We either need to use separate field in build or nested field in deploy. I thing the latter is better since DockerImage also has some other fields like tag

@aguschin
Copy link
Contributor Author

was resolved by Mike already

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
bug Something isn't working cli MLEM command-line interface p1-high High priority ux Things that matter for user experience
Projects
None yet
Development

No branches or pull requests

2 participants