Skip to content
This repository was archived by the owner on Sep 13, 2023. It is now read-only.

Confusing error in deploy run flyio when app exists #667

Closed
aguschin opened this issue Apr 27, 2023 · 2 comments · Fixed by #674
Closed

Confusing error in deploy run flyio when app exists #667

aguschin opened this issue Apr 27, 2023 · 2 comments · Fixed by #674
Labels
bug Something isn't working deploy Related to model deployment plugins Plugins and extensions for MLEM! ux Things that matter for user experience

Comments

@aguschin
Copy link
Contributor

If you created an app (e.g. app-name is test-app-mlem and deployment file is app-first.mlem), but want to use the same fly app (app name) in a different deployment (e.g. app.mlem), you're getting this error.

$ mlem deploy run flyio app.mlem -m model --app_name test-app-mlem --env.org personal --org personaldsa
💾 Saving deployment to app.mlem
⏳️ Loading model from model.mlem
Error: prompt: non interactive

❌ Command '['flyctl', 'launch', '--auto-confirm', '--region', 'lax', '--no-deploy', '--name', 'test-app-mlem', '--org', 'personaldsa']' returned
non-zero exit status 1.

It happens because flyctl asks you to confirm re-deployment. But the error doesn't explain itself anyhow - you'll be left wondering what happened.

@aguschin aguschin added bug Something isn't working ux Things that matter for user experience deploy Related to model deployment plugins Plugins and extensions for MLEM! labels Apr 27, 2023
@aminalaee
Copy link
Contributor

@aguschin I can pick this up.
flyctl has a flag --reuse-app which can be used to Continue even if app name clashes with an existent app. I think this has a side-effect but with the non interactive mode the other option is just to show better errors from the flyctl output.

Let me know. what you think.

@aguschin
Copy link
Contributor Author

@aminalaee, I think using it is fine TBH. Let's apply --reuse-app then.

For the reference, we had an extensive discussion about that in #463, but I don't think we have the capacity to implement it soon, so your suggestion LGTM.

aguschin pushed a commit that referenced this issue May 11, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
bug Something isn't working deploy Related to model deployment plugins Plugins and extensions for MLEM! ux Things that matter for user experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants