This repository was archived by the owner on Sep 13, 2023. It is now read-only.
remote cmd fixes #103
Merged
remote cmd fixes #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mike0sv <mike0sv@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #103 +/- ##
==========================================
+ Coverage 77.64% 78.79% +1.15%
==========================================
Files 52 55 +3
Lines 3055 3282 +227
==========================================
+ Hits 2372 2586 +214
- Misses 683 696 +13
Continue to review full report at Codecov.
|
aguschin
approved these changes
Nov 8, 2021
Comment on lines
29
to
30
| # TODO: do we really need this function? | ||
| # address in https://github.com/iterative/mlem/issues/4 |
There was a problem hiding this comment.
IIRC, this comment was suggesting that maybe we should unite resolve_fs() and get_fs() in one function. Not sure which is better, unite or leave them as is.
There was a problem hiding this comment.
Suggested change
| # TODO: do we really need this function? | |
| # address in https://github.com/iterative/mlem/issues/4 |
In any case, we probably should remove this comment.
There was a problem hiding this comment.
This will be addressed in my next PR
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #31
closes #72
Signed-off-by: mike0sv mike0sv@gmail.com