This repository was archived by the owner on Sep 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #185 +/- ##
==========================================
+ Coverage 87.48% 89.52% +2.03%
==========================================
Files 74 74
Lines 4812 4896 +84
==========================================
+ Hits 4210 4383 +173
+ Misses 602 513 -89
Continue to review full report at Codecov.
|
mike0sv
reviewed
Apr 8, 2022
mike0sv
reviewed
Apr 8, 2022
mike0sv
reviewed
Apr 8, 2022
ec074bb
to
0ce1d07
Compare
@mike0sv we can discuss writing tests a bit. The endpoint
Moreover, since we are using our own client instead of FastAPI's |
@mike0sv ready to merge! |
mike0sv
approved these changes
Apr 13, 2022
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40
I could appreciate a pair session for this task since the ebonite reference is kinda overwhelming -- there are many things I am sure of which we could eliminate. CC: @mike0sv