Skip to content
This repository was archived by the owner on Sep 13, 2023. It is now read-only.

Better error message on extension import error #300

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

mike0sv
Copy link
Contributor

@mike0sv mike0sv commented Jun 15, 2022

closes #200

@mike0sv mike0sv requested a review from a team June 15, 2022 14:28
@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #300 (76ad6a0) into main (b70975d) will decrease coverage by 2.14%.
The diff coverage is 32.00%.

@@            Coverage Diff             @@
##             main     #300      +/-   ##
==========================================
- Coverage   90.32%   88.18%   -2.15%     
==========================================
  Files          77       77              
  Lines        5698     5720      +22     
==========================================
- Hits         5147     5044     -103     
- Misses        551      676     +125     
Impacted Files Coverage Δ
mlem/core/base.py 79.69% <8.33%> (-6.48%) ⬇️
mlem/core/errors.py 81.94% <33.33%> (-6.95%) ⬇️
mlem/ext.py 88.65% <100.00%> (+0.36%) ⬆️
mlem/contrib/docker/helpers.py 50.00% <0.00%> (-50.00%) ⬇️
mlem/contrib/heroku/utils.py 39.34% <0.00%> (-40.99%) ⬇️
mlem/contrib/heroku/meta.py 52.00% <0.00%> (-32.00%) ⬇️
mlem/contrib/heroku/build.py 56.75% <0.00%> (-27.03%) ⬇️
mlem/ui.py 85.50% <0.00%> (-8.70%) ⬇️
mlem/contrib/docker/base.py 81.72% <0.00%> (-5.38%) ⬇️
mlem/core/objects.py 86.46% <0.00%> (-4.99%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b70975d...76ad6a0. Read the comment docs.

Copy link
Contributor

@aguschin aguschin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mike0sv mike0sv merged commit c701297 into main Jun 16, 2022
@mike0sv mike0sv deleted the fix/better-import-errors branch June 16, 2022 12:26
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better error messages for unavailable extensions
2 participants