Skip to content
This repository was archived by the owner on Sep 13, 2023. It is now read-only.

fix for empty nested dicts in DictType #376

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Conversation

mike0sv
Copy link
Contributor

@mike0sv mike0sv commented Aug 10, 2022

reported by @ankxyz in #332

@mike0sv mike0sv requested a review from a team August 10, 2022 11:44
@mike0sv mike0sv temporarily deployed to internal August 10, 2022 11:44 Inactive
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #376 (d65e679) into main (95d521b) will increase coverage by 5.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #376      +/-   ##
==========================================
+ Coverage   84.37%   89.49%   +5.12%     
==========================================
  Files          81       81              
  Lines        6297     6275      -22     
==========================================
+ Hits         5313     5616     +303     
+ Misses        984      659     -325     
Impacted Files Coverage Δ
mlem/core/objects.py 91.42% <ø> (+4.93%) ⬆️
mlem/contrib/callable.py 98.26% <100.00%> (-0.19%) ⬇️
mlem/core/data_type.py 95.09% <100.00%> (ø)
mlem/core/metadata.py 95.91% <100.00%> (+2.93%) ⬆️
mlem/contrib/dvc.py 60.29% <0.00%> (-0.90%) ⬇️
mlem/utils/root.py 91.66% <0.00%> (+0.23%) ⬆️
mlem/core/requirements.py 95.05% <0.00%> (+0.38%) ⬆️
mlem/core/meta_io.py 94.11% <0.00%> (+0.53%) ⬆️
mlem/utils/module.py 90.11% <0.00%> (+0.76%) ⬆️
mlem/api/commands.py 88.88% <0.00%> (+2.22%) ⬆️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mike0sv mike0sv merged commit 86adf2b into main Aug 16, 2022
@mike0sv mike0sv deleted the fix/empty-artifacts-flatdict branch August 16, 2022 12:45
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants