Skip to content
This repository was archived by the owner on Sep 13, 2023. It is now read-only.

create MlemSource to choose how mlem is added to docker #391

Merged
merged 5 commits into from
Sep 5, 2022

Conversation

mike0sv
Copy link
Contributor

@mike0sv mike0sv commented Sep 1, 2022

close #345

@mike0sv mike0sv self-assigned this Sep 1, 2022
@mike0sv mike0sv requested a review from a team September 1, 2022 18:41
@mike0sv mike0sv temporarily deployed to internal September 1, 2022 18:41 Inactive
@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Base: 89.51% // Head: 89.40% // Decreases project coverage by -0.11% ⚠️

Coverage data is based on head (e9ae8b4) compared to base (8a409c8).
Patch coverage: 79.83% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #391      +/-   ##
==========================================
- Coverage   89.51%   89.40%   -0.12%     
==========================================
  Files          81       81              
  Lines        6276     6342      +66     
==========================================
+ Hits         5618     5670      +52     
- Misses        658      672      +14     
Impacted Files Coverage Δ
mlem/cli/dev.py 50.00% <0.00%> (ø)
mlem/cli/main.py 65.48% <0.00%> (-1.18%) ⬇️
mlem/contrib/docker/context.py 85.83% <83.80%> (-1.03%) ⬇️
mlem/utils/entrypoints.py 84.50% <100.00%> (+0.92%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mike0sv mike0sv temporarily deployed to internal September 1, 2022 19:03 Inactive
@mike0sv mike0sv temporarily deployed to internal September 1, 2022 19:09 Inactive
@mike0sv mike0sv temporarily deployed to internal September 1, 2022 19:37 Inactive
@aguschin
Copy link
Contributor

aguschin commented Sep 2, 2022

This closes #345 if I'm correct. Right @mike0sv ?

@mike0sv
Copy link
Contributor Author

mike0sv commented Sep 2, 2022

Lol yes
I forgot that we have it already as an issue :)

Copy link
Contributor

@aguschin aguschin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aguschin aguschin merged commit 387bd4d into main Sep 5, 2022
@aguschin aguschin deleted the feature/mlem-docker-source branch September 5, 2022 07:01
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Run apt-get update before installing unix dependencies
2 participants