Skip to content
This repository was archived by the owner on Sep 13, 2023. It is now read-only.

Error on extra cli arguments #461

Merged
merged 5 commits into from
Nov 1, 2022
Merged

Error on extra cli arguments #461

merged 5 commits into from
Nov 1, 2022

Conversation

mike0sv
Copy link
Contributor

@mike0sv mike0sv commented Oct 28, 2022

I spent 1 hour to find this one
closes #459

@mike0sv mike0sv requested a review from a team October 28, 2022 20:10
@mike0sv mike0sv temporarily deployed to internal October 28, 2022 20:10 Inactive
@mike0sv mike0sv temporarily deployed to internal October 30, 2022 03:41 Inactive
@mike0sv mike0sv temporarily deployed to internal October 31, 2022 10:13 Inactive
@mike0sv mike0sv temporarily deployed to internal October 31, 2022 10:14 Inactive
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Base: 58.93% // Head: 82.62% // Increases project coverage by +23.69% 🎉

Coverage data is based on head (fefceaf) compared to base (c720634).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #461       +/-   ##
===========================================
+ Coverage   58.93%   82.62%   +23.69%     
===========================================
  Files          95       96        +1     
  Lines        7889     7811       -78     
===========================================
+ Hits         4649     6454     +1805     
+ Misses       3240     1357     -1883     
Impacted Files Coverage Δ
mlem/cli/main.py 84.14% <100.00%> (+26.01%) ⬆️
mlem/contrib/heroku/utils.py 24.59% <0.00%> (-55.74%) ⬇️
mlem/contrib/docker/helpers.py 50.00% <0.00%> (-50.00%) ⬇️
mlem/contrib/heroku/build.py 55.17% <0.00%> (-34.49%) ⬇️
mlem/contrib/heroku/meta.py 51.35% <0.00%> (-33.79%) ⬇️
mlem/contrib/docker/utils.py 30.39% <0.00%> (-30.78%) ⬇️
mlem/contrib/docker/base.py 42.49% <0.00%> (-15.33%) ⬇️
mlem/cli/dev.py 47.36% <0.00%> (-2.64%) ⬇️
mlem/ui.py 86.11% <0.00%> (-1.89%) ⬇️
mlem/contrib/sagemaker/build.py 57.37% <0.00%> (-1.36%) ⬇️
... and 66 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aguschin
Copy link
Contributor

aguschin commented Nov 1, 2022

Curious why black pre-commit failed in CI. Pushing a fix anyway :)

@aguschin aguschin temporarily deployed to internal November 1, 2022 09:53 Inactive
Copy link
Contributor

@aguschin aguschin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@aguschin aguschin merged commit 39bb750 into main Nov 1, 2022
@aguschin aguschin deleted the fix/cli-extra-args branch November 1, 2022 10:09
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Raise error on passing wrong options
2 participants