Skip to content
This repository was archived by the owner on Sep 13, 2023. It is now read-only.

Suggest running heroku login on missing creds #503

Merged
merged 2 commits into from
Nov 25, 2022

Conversation

mike0sv
Copy link
Contributor

@mike0sv mike0sv commented Nov 25, 2022

closes #501

@mike0sv mike0sv requested a review from a team November 25, 2022 11:27
@mike0sv mike0sv temporarily deployed to internal November 25, 2022 11:27 Inactive
@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Base: 87.99% // Head: 86.46% // Decreases project coverage by -1.52% ⚠️

Coverage data is based on head (37b5b32) compared to base (75e2074).
Patch coverage: 89.24% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #503      +/-   ##
==========================================
- Coverage   87.99%   86.46%   -1.53%     
==========================================
  Files          96       96              
  Lines        8282     8654     +372     
==========================================
+ Hits         7288     7483     +195     
- Misses        994     1171     +177     
Impacted Files Coverage Δ
mlem/contrib/rabbitmq.py 53.08% <37.50%> (-45.71%) ⬇️
mlem/contrib/heroku/utils.py 88.88% <50.00%> (+8.56%) ⬆️
mlem/contrib/sagemaker/runtime.py 80.64% <71.42%> (+0.98%) ⬆️
mlem/contrib/fastapi.py 84.74% <76.19%> (-11.09%) ⬇️
mlem/runtime/client.py 84.84% <79.41%> (-5.95%) ⬇️
mlem/contrib/lightgbm.py 94.35% <81.81%> (+0.23%) ⬆️
mlem/runtime/server.py 88.31% <88.23%> (+3.01%) ⬆️
mlem/core/data_type.py 92.63% <89.61%> (-2.93%) ⬇️
mlem/runtime/interface.py 87.50% <93.18%> (+2.39%) ⬆️
mlem/contrib/torch.py 93.91% <95.00%> (+0.16%) ⬆️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mike0sv mike0sv temporarily deployed to internal November 25, 2022 12:00 Inactive
@aguschin aguschin merged commit afb18db into main Nov 25, 2022
@aguschin aguschin deleted the fix/heroku-login-suggest branch November 25, 2022 14:08
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error message when failing to log into Heroku
2 participants