Skip to content
This repository was archived by the owner on Sep 13, 2023. It is now read-only.

importlib_metadata dependency #534

Merged
merged 3 commits into from
Dec 20, 2022
Merged

importlib_metadata dependency #534

merged 3 commits into from
Dec 20, 2022

Conversation

mike0sv
Copy link
Contributor

@mike0sv mike0sv commented Dec 20, 2022

No description provided.

@mike0sv mike0sv requested a review from a team December 20, 2022 11:43
@mike0sv mike0sv temporarily deployed to internal December 20, 2022 11:43 — with GitHub Actions Inactive
@mike0sv mike0sv temporarily deployed to internal December 20, 2022 14:35 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Base: 83.49% // Head: 86.78% // Increases project coverage by +3.28% 🎉

Coverage data is based on head (1eda7a8) compared to base (3d9f885).
Patch has no changes to coverable lines.

❗ Current head 1eda7a8 differs from pull request most recent head 4d22be1. Consider uploading reports for the commit 4d22be1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #534      +/-   ##
==========================================
+ Coverage   83.49%   86.78%   +3.28%     
==========================================
  Files         102      102              
  Lines        9242     9242              
==========================================
+ Hits         7717     8021     +304     
+ Misses       1525     1221     -304     
Impacted Files Coverage Δ
mlem/core/objects.py 87.03% <0.00%> (+2.04%) ⬆️
mlem/api/utils.py 78.18% <0.00%> (+5.45%) ⬆️
mlem/api/commands.py 88.27% <0.00%> (+5.51%) ⬆️
mlem/ui.py 94.66% <0.00%> (+8.00%) ⬆️
mlem/contrib/kubernetes/service.py 51.72% <0.00%> (+10.34%) ⬆️
mlem/contrib/kubernetes/build.py 100.00% <0.00%> (+30.00%) ⬆️
mlem/contrib/docker/base.py 85.26% <0.00%> (+35.73%) ⬆️
mlem/contrib/kubernetes/base.py 85.29% <0.00%> (+36.27%) ⬆️
mlem/contrib/kubernetes/utils.py 63.15% <0.00%> (+42.10%) ⬆️
mlem/contrib/rabbitmq.py 98.76% <0.00%> (+45.67%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aguschin
Copy link
Contributor

great! I see one issue in failing test - it doesn't check packages like package>1 or package<0.0.1, only packages like package or package==0.0.1. I'll fix that test a bit later and will merge this.

@aguschin aguschin temporarily deployed to internal December 20, 2022 15:36 — with GitHub Actions Inactive
@aguschin aguschin merged commit 66ad871 into main Dec 20, 2022
@aguschin aguschin deleted the fix/importlib-metadata branch December 20, 2022 15:38
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants