Skip to content
This repository was archived by the owner on Sep 13, 2023. It is now read-only.

Update GH workflow #561

Merged
merged 4 commits into from
Jan 10, 2023
Merged

Update GH workflow #561

merged 4 commits into from
Jan 10, 2023

Conversation

aguschin
Copy link
Contributor

  1. This needs to be checked by creating a dummy PR that updates this branch. To run the workflow here.
  2. This breaks CI - see https://github.com/iterative/mlem/actions/runs/3808281067/jobs/6478727408. Need to be fixed before merge

@aguschin aguschin requested a review from a team December 30, 2022 17:55
@aguschin aguschin temporarily deployed to internal December 30, 2022 17:55 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Dec 30, 2022

Codecov Report

Base: 86.77% // Head: 86.78% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (35e6072) compared to base (749b8d9).
Patch has no changes to coverable lines.

❗ Current head 35e6072 differs from pull request most recent head 7cac7e7. Consider uploading reports for the commit 7cac7e7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #561      +/-   ##
==========================================
+ Coverage   86.77%   86.78%   +0.01%     
==========================================
  Files         102      102              
  Lines        9261     9261              
==========================================
+ Hits         8036     8037       +1     
+ Misses       1225     1224       -1     
Impacted Files Coverage Δ
mlem/utils/module.py 91.90% <0.00%> (+0.35%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aguschin aguschin assigned mike0sv and aguschin and unassigned mike0sv Jan 9, 2023
@aguschin aguschin temporarily deployed to internal January 10, 2023 11:35 — with GitHub Actions Inactive
@aguschin
Copy link
Contributor Author

Eh, the problem is for Windows - looks like echo "PIP_CACHE_DIR=$(pip cache dir)" >> $GITHUB_ENV doesn't add an env var.

@skshetry
Copy link
Member

@aguschin, setup-python has in-built caching now, you can get rid of most of the code here:

https://github.com/actions/setup-python/blob/main/docs/advanced-usage.md#caching-packages.

@aguschin aguschin temporarily deployed to internal January 10, 2023 13:16 — with GitHub Actions Inactive
@aguschin aguschin temporarily deployed to internal January 10, 2023 13:48 — with GitHub Actions Inactive
@aguschin aguschin merged commit 0be0551 into main Jan 10, 2023
@aguschin aguschin deleted the actions-update branch January 10, 2023 13:49
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants