Skip to content
This repository was archived by the owner on Sep 13, 2023. It is now read-only.

Allow rerunning deploy without --load if deployment meta is going to be the same #570

Merged
merged 3 commits into from
Jan 16, 2023

Conversation

aguschin
Copy link
Contributor

@aguschin aguschin commented Jan 13, 2023

If meta is different, it will error out now

$ mlem deploy run heroku heroku.mlem --model player --app_name hat-player2
⏳️ Loading deployment from heroku.mlem
❌ Different deployment meta already exists at path='/Users/aguschin/Git/iterative/mlem/hat-player/heroku.mlem' project=None rev=None
uri='file:///Users/aguschin/Git/iterative/mlem/hat-player/heroku.mlem' project_uri=None fs=<fsspec.implementations.local.LocalFileSystem object at
0x10c230760>. Please use `mlem deployment run --load <path> ...`

but if it's the same, it will go on:

$ mlem --tb deploy run heroku heroku.mlem --model player --app_name hat-player
⏳️ Loading deployment from heroku.mlem
⏳️ Loading model from player.mlem
🛠 Creating docker image for heroku
...

see #463 (comment) for discussion

@aguschin aguschin requested a review from a team January 13, 2023 12:56
@aguschin aguschin self-assigned this Jan 13, 2023
@aguschin aguschin temporarily deployed to internal January 13, 2023 12:57 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Base: 86.77% // Head: 86.84% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (e4b174e) compared to base (749b8d9).
Patch coverage: 94.73% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #570      +/-   ##
==========================================
+ Coverage   86.77%   86.84%   +0.07%     
==========================================
  Files         102      102              
  Lines        9261     9290      +29     
==========================================
+ Hits         8036     8068      +32     
+ Misses       1225     1222       -3     
Impacted Files Coverage Δ
mlem/contrib/pip/base.py 100.00% <ø> (ø)
mlem/core/base.py 84.80% <90.90%> (+0.08%) ⬆️
mlem/utils/module.py 91.52% <92.85%> (-0.03%) ⬇️
mlem/cli/config.py 96.07% <100.00%> (+0.52%) ⬆️
mlem/cli/deployment.py 92.75% <100.00%> (+1.98%) ⬆️
mlem/config.py 95.53% <0.00%> (+1.78%) ⬆️
mlem/core/errors.py 85.00% <0.00%> (+2.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@mike0sv mike0sv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test?

@aguschin aguschin temporarily deployed to internal January 16, 2023 08:13 — with GitHub Actions Inactive
@aguschin aguschin temporarily deployed to internal January 16, 2023 10:01 — with GitHub Actions Inactive
@aguschin aguschin merged commit 8dfcf24 into main Jan 16, 2023
@aguschin aguschin deleted the fix/repeating-deploy-rerun branch January 16, 2023 10:46
@aguschin aguschin added the p0-critical Critical priority label Jan 16, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
p0-critical Critical priority
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants