This repository was archived by the owner on Sep 13, 2023. It is now read-only.
Feature/better signatures #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mike0sv <mike0sv@gmail.com>
* Specify issues for todos Signed-off-by: mike0sv <mike0sv@gmail.com> * create few issues and add links to them in code, making tests work with `example-mlem` repo Co-authored-by: Alexander Guschin <1aguschin@gmail.com>
* add GHA to release on pypi, fix some tests
Signed-off-by: mike0sv <mike0sv@gmail.com>
# Conflicts: # mlem/api/commands.py # mlem/contrib/xgboost.py # mlem/core/dataset_type.py # mlem/core/requirements.py # mlem/utils/root.py
closes #21 Signed-off-by: mike0sv <mike0sv@gmail.com>
aguschin
reviewed
Oct 8, 2021
aguschin
added
breaking-change
aguschin
reviewed
Oct 8, 2021
| ), | ||
| ) | ||
|
|
||
| expected_requirements = {"catboost", "pandas", "numpy"} |
There was a problem hiding this comment.
BTW, why we have pandas here and don't have it in tests for sklearn, lighgbm, xgboost? Does it come from "install_requires" each library has?
There was a problem hiding this comment.
it's because we use pandas data for input
There was a problem hiding this comment.
Ok, so ideally we would have to add tests for both numpy and pandas data, right?
Codecov Report
@@ Coverage Diff @@
## main #62 +/- ##
=======================================
Coverage ? 75.97%
=======================================
Files ? 52
Lines ? 3038
Branches ? 0
=======================================
Hits ? 2308
Misses ? 730
Partials ? 0 Continue to review full report at Codecov.
|
aguschin
reviewed
Oct 8, 2021
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #21