Skip to content
This repository was archived by the owner on Sep 13, 2023. It is now read-only.

Fix platform setting for building image for sagemaker #632

Merged
merged 2 commits into from
Mar 13, 2023
Merged

Fix platform setting for building image for sagemaker #632

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6dcad63
Fix platform setting for building image for sagemaker
mike0sv Mar 8, 2023
7905085
Merge branch 'main' into fix/sagemaker-docker-platform
aguschin Mar 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions mlem/contrib/sagemaker/build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

from ...core.objects import MlemModel
from ...ui import EMOJI_BUILD, EMOJI_KEY, echo, set_offset
from ..docker.base import DockerEnv, DockerImageOptions, RemoteRegistry
from ..docker.base import DockerImageOptions, RemoteRegistry
from ..docker.helpers import build_model_image

IMAGE_NAME = "mlem-sagemaker-runner"
Expand Down Expand Up @@ -119,10 +119,8 @@ def build_sagemaker_docker(
):
from .runtime import SageMakerServer # circular import

docker_env = DockerEnv(
registry=ECRegistry(account=account, region=region).with_aws_vars(
aws_vars
)
ec_registry = ECRegistry(account=account, region=region).with_aws_vars(
aws_vars
)
ecr_repo_check(region, repository, aws_vars.get_session())
echo(EMOJI_BUILD + "Creating docker image for sagemaker")
Expand All @@ -132,7 +130,8 @@ def build_sagemaker_docker(
name=repository,
tag=image_name,
server=SageMakerServer(method=method),
env=docker_env,
registry=ec_registry,
force_overwrite=True,
templates_dir=[os.path.dirname(__file__)],
platform="linux/amd64",
)