Skip to content
This repository was archived by the owner on Sep 13, 2023. It is now read-only.

Improved logging #67

Merged
merged 4 commits into from
Oct 11, 2021
Merged

Improved logging #67

merged 4 commits into from
Oct 11, 2021

Conversation

mike0sv
Copy link
Contributor

@mike0sv mike0sv commented Oct 8, 2021

closes #6

@mike0sv mike0sv self-assigned this Oct 8, 2021
@mike0sv mike0sv requested a review from a team October 8, 2021 15:06
mike0sv and others added 2 commits October 11, 2021 12:38
Signed-off-by: mike0sv <mike0sv@gmail.com>
Co-authored-by: Alexander Guschin <1aguschin@gmail.com>
@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #67 (bcc46fd) into main (0574ba3) will increase coverage by 0.55%.
The diff coverage is 95.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
+ Coverage   75.93%   76.49%   +0.55%     
==========================================
  Files          52       52              
  Lines        3038     3067      +29     
==========================================
+ Hits         2307     2346      +39     
+ Misses        731      721      -10     
Impacted Files Coverage Δ
mlem/log.py 85.71% <ø> (-1.79%) ⬇️
mlem/cli/main.py 83.33% <80.00%> (-16.67%) ⬇️
mlem/core/metadata.py 92.45% <88.88%> (+0.14%) ⬆️
mlem/__init__.py 100.00% <100.00%> (ø)
mlem/cli/apply.py 91.30% <100.00%> (ø)
mlem/cli/deploy.py 50.00% <100.00%> (ø)
mlem/cli/env.py 73.33% <100.00%> (+1.90%) ⬆️
mlem/cli/get.py 66.66% <100.00%> (ø)
mlem/cli/info.py 100.00% <100.00%> (+22.50%) ⬆️
mlem/cli/init.py 71.42% <100.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 322cc74...bcc46fd. Read the comment docs.

Copy link
Contributor

@aguschin aguschin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥
UPD: for the record, this PR bring functionality of controlling verbosity in CLI commands with --verbose flag, like this:

mlem some-command -v
mlem some-command --verbose

@mike0sv mike0sv merged commit 82bda1a into main Oct 11, 2021
@mike0sv mike0sv deleted the feature/better-logging branch October 11, 2021 11:30
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make standard logging for all MLEM parts
2 participants