Skip to content
This repository was archived by the owner on Sep 13, 2023. It is now read-only.

Fix Flyio GH action #672

Merged
merged 2 commits into from
May 11, 2023
Merged

Fix Flyio GH action #672

merged 2 commits into from
May 11, 2023

Conversation

aminalaee
Copy link
Contributor

@aminalaee aminalaee commented May 11, 2023 •
edited
Loading

Fix Flyio Github action

@aminalaee aminalaee requested a review from a team May 11, 2023 08:24
@aminalaee aminalaee temporarily deployed to internal May 11, 2023 08:24 — with GitHub Actions Inactive
@aminalaee aminalaee requested a review from aguschin May 11, 2023 08:37
@aguschin aguschin mentioned this pull request May 11, 2023
Closed
@aguschin aguschin temporarily deployed to internal May 11, 2023 10:10 — with GitHub Actions Inactive
@aminalaee
Copy link
Contributor Author

You are right about pytest -k 'not heroku and not flyctl' but I think the dummy PR passed the pipeline. This PR is still using the old action, right?

@aguschin
Copy link
Contributor

I think the dummy PR passed the pipeline

Yes, looks like that!

This PR is still using the old action, right?

Yes.

@aguschin
Copy link
Contributor

Yes, CI finished. There was some error with catboost, I've seen it in earlier PRs. We'll need to fix it, if it doesn't take care of itself, in order to release next version of MLEM. Merging! Thanks for the quick fix @aminalaee !

aguschin
aguschin approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@aguschin aguschin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@aguschin aguschin merged commit 5e450b0 into main May 11, 2023
@aguschin aguschin deleted the fix-flyio-action branch May 11, 2023 11:13
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@aguschin aguschin aguschin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aminalaee @aguschin