Skip to content
This repository was archived by the owner on Sep 13, 2023. It is now read-only.

ls command #89

Merged
merged 10 commits into from
Oct 25, 2021
Merged

ls command #89

merged 10 commits into from
Oct 25, 2021

Conversation

mike0sv
Copy link
Contributor

@mike0sv mike0sv commented Oct 21, 2021

closes #14

Signed-off-by: mike0sv mike0sv@gmail.com

@mike0sv
ls command
5af6179 
closes #14

Signed-off-by: mike0sv <mike0sv@gmail.com>
@mike0sv mike0sv requested a review from aguschin October 21, 2021 21:06
@mike0sv mike0sv self-assigned this Oct 21, 2021
@mike0sv mike0sv requested a review from a team October 21, 2021 21:06
@codecov
Copy link

codecov bot commented Oct 22, 2021 •
edited
Loading

Codecov Report

Merging #89 (219edc9) into main (1de6e4f) will increase coverage by 0.37%.
The diff coverage is 98.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   77.26%   77.64%   +0.37%     
==========================================
  Files          52       52              
  Lines        3026     3055      +29     
==========================================
+ Hits         2338     2372      +34     
+ Misses        688      683       -5
Impacted Files Coverage Δ
mlem/api/commands.py 75.96% <96.29%> (+6.34%) ⬆️
mlem/cli/info.py 97.72% <100.00%> (-2.28%) ⬇️
mlem/core/objects.py 86.66% <100.00%> (+0.47%) ⬆️
mlem/utils/root.py 100.00% <0.00%> (ø)
mlem/core/requirements.py 68.91% <0.00%> (+2.59%) ⬆️
mlem/version.py 72.22% <0.00%> (+2.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27f5bae...219edc9. Read the comment docs.

aguschin
aguschin approved these changes Oct 22, 2021
View reviewed changes
mike0sv and others added 3 commits October 24, 2021 14:10
@mike0sv @aguschin
Update .github/workflows/check-test-release.yml
59c9e85 
Co-authored-by: Alexander Guschin <1aguschin@gmail.com>
@mike0sv
Merge branch 'main' into feature/api-ls
9315f68
@mike0sv
better cli arguments
a1b48d0 
Signed-off-by: mike0sv <mike0sv@gmail.com>
@aguschin aguschin mentioned this pull request Oct 25, 2021
Closed
2 tasks
aguschin
aguschin approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@aguschin aguschin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had few questions, but nothing major.

@aguschin aguschin added api MLEM Python API model registry Model registry functionality of MLEM labels Oct 25, 2021
mike0sv and others added 2 commits October 25, 2021 18:17
@mike0sv @aguschin
Update tests/conftest.py
b87e759 
Co-authored-by: Alexander Guschin <1aguschin@gmail.com>
@mike0sv @aguschin
Update mlem/api/commands.py
219edc9 
Co-authored-by: Alexander Guschin <1aguschin@gmail.com>
aguschin
aguschin approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@aguschin aguschin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Let's merge this! 🚒

@mike0sv mike0sv merged commit 312c496 into main Oct 25, 2021
@mike0sv mike0sv deleted the feature/api-ls branch October 25, 2021 15:39
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@aguschin aguschin aguschin approved these changes

Assignees

@mike0sv mike0sv

Labels
api MLEM Python API model registry Model registry functionality of MLEM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Design mlem.api.list() for common model registry case
2 participants
@mike0sv @aguschin