Empty buckets during Delete() #420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x2b3bfa0
added
bug
0x2b3bfa0
force-pushed
the
388-`task`-status-is-confusing-and-not-working-properly
branch
from
befe5ac to
125440f
Compare
0x2b3bfa0
force-pushed
the
388-`task`-status-is-confusing-and-not-working-properly
branch
from
876f569 to
06f8c4a
Compare
Weird. For me takes close to 10min almost constantly. I have to sync 20 files of 1KB each, but aside that... |
|
🥶 Only on Azure? |
|
@0x2b3bfa0 K8 test is failing |
|
❄️ Flaky, not related to this pull request. willfix |
DavidGOrtega
approved these changes
Mar 7, 2022
There was a problem hiding this comment.
👍
Tested it does not totally fix #388 but the biggest issue is working right now perfectly or I was not able to reproduce it 🎉
|
@DavidGOrtega, please always run |
|
@DavidGOrtega: all green in 3, 2, 1, ... 🚀 |
DavidGOrtega
deleted the
388-`task`-status-is-confusing-and-not-working-properly
branch
Merged
This was referenced Mar 24, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would fix #388
azconsistency issue and adds debug output to diagnose further status inconsistencies. Additionally, simplifies all the bucket emptying logic by usingrcloneinstead of provider–specific code.Side note: these changes are also a small step towards #299.