-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Update "No Plots" section message #4793
Conversation
Defer to @shcheklein |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just my personal opinion, I'd add a new line for the new text. Shorter lines are easier to read.
Thanks @julieg18 ! Let's be super explicit here: No plots or data to display. Also, let's please review some other places where we have a similar message. |
Updated the title and added the additional message in empty plot sections: ![]() ![]() ![]() cc @shcheklein |
Look good to me, thanks @julieg18 ! |
Code Climate has analyzed commit f658319 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.0% (0.0% change). View more on Code Climate. |
Demo
https://github.com/iterative/vscode-dvc/assets/43496356/2e854bb5-587c-46ad-aa14-727d8c6200f9Fixes #4462