Improve validation of Plot Wizard Y metrics quick pick #4827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julieg18
commented
Oct 13, 2023
| return { | ||
| fields: { x, y }, | ||
| firstXKey: (xValues as QuickPickFieldValues)[0].field, | ||
| firstYKey: (yValues as QuickPickFieldValues)[0].field |
There was a problem hiding this comment.
Missed this earlier, we were using key instead of field.
| { | ||
| title: `Select ${xFieldsLength} Metrics for Y` as Title | ||
| }, | ||
| xFieldsLength |
There was a problem hiding this comment.
One issue with the quick pick is that we lose separators (aka file names) when the items are collapsed:
| const y = | ||
| xValuesLength > 1 | ||
| ? await pickYFieldsWithMultiXFields(yItems, xValuesLength) | ||
| : await pickYFields(yItems) |
There was a problem hiding this comment.
With this change, y fields are picked and validated differently depending on if there are multiple x values.
sroy3
approved these changes
Oct 13, 2023
|
Code Climate has analyzed commit 5c43e0d and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 95.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.0% (0.0% change). View more on Code Climate. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo
Screen.Recording.2023-10-13.at.10.54.23.AM.mov
Followup to #4789 comment