Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix quickPickUserOrderedValues windows test timing out #4879

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

julieg18
Copy link
Contributor

@julieg18 julieg18 commented Oct 24, 2023

One of tests for quickPickUserOrderedValues is failing frequently with a timeout error in windows:

         quickPickUserOrderedValues
           should limit the number of values that can be selected to the max selected items:
       Error: Timeout of 6000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (d:\a\vscode-dvc\vscode-dvc\extension\dist\test\suite\vscode\quickPick.test.js)

@@ -200,11 +200,7 @@ suite('Quick Pick Test Suite', () => {
{ label: 'B', value: 2 },
{ label: 'C', value: 3 },
{ label: 'D', value: 4 },
{ label: 'E', value: 5 },
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the test, I don't think there is a bug inside the test but there are a lot of commands being run in selectMultipleQuickPickItems due to needing to repeatedly loop over the items. Possibly why the test keeps hitting a timeout 🤔

I've decreased the number of quick pick items and added 2000ms to the timeout.

@julieg18 julieg18 marked this pull request as ready for review October 24, 2023 16:01
@julieg18 julieg18 enabled auto-merge (squash) October 25, 2023 12:07
@codeclimate
Copy link

codeclimate bot commented Oct 25, 2023

Code Climate has analyzed commit 82fd839 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.0% (0.0% change).

View more on Code Climate.

@julieg18 julieg18 merged commit 3333859 into main Oct 25, 2023
@julieg18 julieg18 deleted the stop-vscode-test-timing-out branch October 25, 2023 13:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants