Remove base64 encoding of Secret #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verified that we do not need to base64 it: > You do not need to pre-encode it. Simply place your []byte data there - https://github.com/munnerz https://kubernetes.slack.com/archives/C0EG7JC6T/p1602695088211400?thread_ts=1602693575.207000&cid=C0EG7JC6T Also see the docs for `Data`: https://github.com/kubernetes/kubernetes/blob/6718c7654d29fafc0ee846247956839e91bce508/staging/src/k8s.io/api/core/v1/types.go#L5626-L5631
|
Good catch, I would prefer a PR with tests updated. If needed I should be able to have a PR this weekend with this and tests included. |
|
@mcavoyk I updated the tests ✅ |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR removes base64 encoding. I verified that we do not need to base64 encode:
https://kubernetes.slack.com/archives/C0EG7JC6T/p1602695088211400?thread_ts=1602693575.207000&cid=C0EG7JC6T
Also see the docs for
Data:https://github.com/kubernetes/kubernetes/blob/6718c7654d29fafc0ee846247956839e91bce508/staging/src/k8s.io/api/core/v1/types.go#L5626-L5631
Which issue this PR fixes
Fixes #52
Other notes for your reviewer:
Release note: