Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Channel: parse subscriber count and channel banner #4785

Conversation

ChunkyProgrammer
Copy link
Contributor

@ChunkyProgrammer ChunkyProgrammer commented Jul 9, 2024

This PR adds support for parsing the newer channel header format (banner + subscription parsing)

Left: Before this change (screenshot from a public instance)
Right: After this change
image

closes #4783

@ChunkyProgrammer ChunkyProgrammer requested a review from a team as a code owner July 9, 2024 17:32
@ChunkyProgrammer ChunkyProgrammer requested review from SamantazFox and removed request for a team July 9, 2024 17:32
@ChunkyProgrammer ChunkyProgrammer force-pushed the parse-subscriber-count-and-channel-banner branch from 56b3fb1 to 3db592e Compare July 9, 2024 17:34
@ChunkyProgrammer ChunkyProgrammer force-pushed the parse-subscriber-count-and-channel-banner branch from 3db592e to 911dad6 Compare July 9, 2024 18:43
@syeopite syeopite added the need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something label Jul 9, 2024
@SamantazFox SamantazFox added ready and removed need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something labels Jul 19, 2024
@SamantazFox SamantazFox merged commit 325561e into iv-org:master Jul 21, 2024
7 checks passed
@SamantazFox
Copy link
Member

Thanks for your contribution!

@ChunkyProgrammer ChunkyProgrammer deleted the parse-subscriber-count-and-channel-banner branch July 21, 2024 16:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Channel banner and number of subscribers are not loaded
3 participants