Dependency updates / trivial fixes #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compatibility with CMake < 3.5 is beeing deprecated starting from CMake 3.27: https://cmake.org/cmake/help/latest/release/3.27.html#deprecated-and-removed-features Signed-off-by: Christian Eggers <ceggers@arri.de>
test/socket-test/main.cc:76:9: error: ‘fd_set’ was not declared in this scope test/socket-test/main.cc:79:27: error: ‘rdfs’ was not declared in this scope ... Signed-off-by: Christian Eggers <ceggers@arri.de>
deps/fmt/include/fmt/core.h:361:6: warning: identifier ‘char8_t’ is a keyword in C++20 [-Wc++20-compat] socket-test links fine without fmt/src/posix.cc (this has been renamed to os.cc) Signed-off-by: Christian Eggers <ceggers@arri.de>
deps/etl/include/etl/map.h:577:34: warning: ‘template<class _Category, class _Tp, class _Distance, class _Pointer, class _Reference> struct std::iterator’ is deprecated [-Wdeprecated-declarations] Separate inclusion of <etl/array.h> is required as this header is not leaked via <etl/map.h> anymore. Signed-off-by: Christian Eggers <ceggers@arri.de>
Catch2 < v2.13.5 does not work with glibc >= 2.34 as MINSIGSTKSZ and SIGSTKSZ are not constant anymore on Linux: https://sourceware.org/pipermail/libc-alpha/2021-August/129718.html test/unit-test/catch.hpp:9041:58: error: call to non-‘constexpr’ function ‘long int sysconf(int)’ 9041 | constexpr static std::size_t sigStackSize = 32768 >= MINSIGSTKSZ ? 32768 : MINSIGSTKSZ; This is been been addressed by Catch2 here: https://github.com/catchorg/Catch2/blob/v2.x/docs/release-notes.md#2135 Include Catch2 via Git submodule as done for other dependencies. Signed-off-by: Christian Eggers <ceggers@arri.de>
Signed-off-by: Christian Eggers <ceggers@arri.de>
Just for clarity / constistency with other operations, the result is the same. Signed-off-by: Christian Eggers <ceggers@arri.de>
Signed-off-by: Christian Eggers <ceggers@arri.de>
Signed-off-by: Christian Eggers <ceggers@arri.de>
|
Hey, I'll take a look at this on weekend, thanks. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Łukasz,
I am just evaluating your comprehensive cpp-can-isotp library. In order to be compatible with
my compiler / C++ library, I had to update the external dependencies first.
I cannot yet tell yet whether I will actually use it in my STM32 project. I would like to exchange NanoPb
messages via ISO-TP, preferably transferring the encoded data on-the-fly (without requiring an intermediate
buffer for the full ISO-TP message).
Please let me know whether contributions are still welcome.