Use Keyword/Map get_lazy function when computing default values
#52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thank you! |
|
Hi @dimitarvp , I'd like to have this feature implemented after implementing BIP32, but I've been very busy with the frontend side of my projects(qunitx, emberx, memoria) thus couldn't really work on the Feel free to reach out over DM: izelnakri#8658 on discord, @izelnakri on Telegram. I'll try to help in any way I can. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that
estimate_gaswill always be called even if I already put agas_limitin my transaction. This PR makes sure that all computed values forKeyword.getandMap.getwill get computed lazily which entails changing those calls toKeyword.get_lazyandMap.get_lazy, respectively.