-
Notifications
You must be signed in to change notification settings - Fork 370
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Correct replace_outside_quotes error handling
- Loading branch information
1 parent
318d7cd
commit 47f6dea
Showing
1 changed file
with
9 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47f6dea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is adding the new class
IdiormStringException
necessary? Perhaps use a one of PHP's built-in Exceptions instead, such asUnexpectedValueException
orLogicException
?I mention this as one alternative, as the new exception class has implications for correcting autoloading (re j4mie/paris#32).
47f6dea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version 1.* of both Paris and Idiorm are intended as simple, easy to drop in ORM and active record classes. So your suggestion in j4mie/paris#32 will not be implemented until at best a version 2 release as it is a BC break to separate classes out for the sake of easier composer autoloading. Not everyone is using composer and certainly not for Idiorm and Paris as it has only just been released.
Whilst it is not strictly necessary to include a separate exception I like to be able to easily catch exceptions so this makes it much more explicit.