Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Named placeholders and raw_query #219

Closed
mgalang opened this issue Jun 23, 2014 · 2 comments
Closed

Named placeholders and raw_query #219

mgalang opened this issue Jun 23, 2014 · 2 comments

Comments

@mgalang
Copy link

mgalang commented Jun 23, 2014

Named placeholders does not work anymore when using raw_query

ref: https://github.com/j4mie/idiorm/blob/master/idiorm.php#L415

commit: 6a9b77c:

Yep, that is gonna be the case - I hadn't noticed before. The problem here is the the for loop is trouncing the named param with a ordered/positional/integer one.

@charsleysa
Copy link
Contributor

This has been fixed but the unit tests and query logging do not currently support named parameters, as far as I know they never have.

@treffynnon
Copy link
Collaborator

That is right, @charsleysa , the query logging doesn't support this, which means that the unit tests can't really be written. We would need to make the logger understand placeholders before we could write tests unfortunately.

treffynnon added a commit that referenced this issue Jun 23, 2014
Fix for #219: binding named parameters broken
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants