update to 3.6.0-stable and ignore META-INF entry when making project.xml #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignore META-INF entry when making project.xml
|
@tonihele @MeFisto94 Could either of you check if you find this to be OK? I want a second opinion before merging :) |
|
At least locally on Linux it works fine! And I would say finally because the LWJGL 2 previously blocked me on working on Linux. I simply tested ./gradlew run on this branch. We can revert it also later if some problems arise. Maybe just better to go forward. Have a jME 3.6 release with working Gradle assets and all that goodness. Hoping Java 17 would solve the file dialog slowness issues... |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is a great solution, but it seems to work when i build locally.