Work around for #176 "Scene graph is not properly updated for renderi…

[neph1]

…ng" when adding LightProbe to a Geometry.

It seems the issue happens inside LightProbeFactory. I think this is an acceptable solution for now, since the consequences of the error are pretty bad.

If someone really wants a LightProbe for just one Geometry, they can replicate it by adding the Geometry to a Node and add the LightProbe to that.

[tonihele]

Hmm, or is it that now the modification happens from the Swing thread. And instead it should be added in jME render thread? With the enqueue.

…

On Tue, 4 Apr 2023, 22:19 Rickard Edén, ***@***.***> wrote: …ng" when adding LightProbe to a Geometry. It seems the issue happens inside LightProbeFactory. I think this is an acceptable solution for now, since the consequences of the error are pretty bad. If someone really wants a LightProbe for just one Geometry, they can replicate it by adding the Geometry to a Node and add the LightProbe to that. ------------------------------ You can view, comment on, or merge this pull request online at: #490 Commit Summary - aa453c3 <aa453c3> Work around for #176 "Scene graph is not properly updated for rendering" when adding LightProbe to a Geometry. File Changes (1 file <https://github.com/jMonkeyEngine/sdk/pull/490/files>) - *M* jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/actions/NewLightPopup.java <https://github.com/jMonkeyEngine/sdk/pull/490/files#diff-11723da5c6b99064b32ba4244250733ca49319b1f09859a72e79198954f16e9e> (7) Patch Links: - https://github.com/jMonkeyEngine/sdk/pull/490.patch - https://github.com/jMonkeyEngine/sdk/pull/490.diff — Reply to this email directly, view it on GitHub <#490>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB7VJPTPG2MLFTOIO7DM6YTW7RX3RANCNFSM6AAAAAAWTEC5ZA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[neph1]

My first test was to comment out:

node.addLight(lightProbe);
node.updateModelBound();

And it still happened

Edit:
The action itself is enqueued, but iiirc LightProbeFactory is doing things async

[neph1]

This is probably the culprit:
EnvironmentCamera:

@Override
    public void render(final RenderManager renderManager) {
        if (isBusy()) {
            final SnapshotJob job = jobs.get(0);

            for (int i = 0; i < 6; i++) {
                viewports[i].clearScenes();
                viewports[i].attachScene(job.scene);
                renderManager.renderViewPort(viewports[i], 0.16f);
                buffers[i] = BufferUtils.createByteBuffer(
                        size * size * imageFormat.getBitsPerPixel() / 8);
                renderManager.getRenderer().readFrameBufferWithFormat(
                        framebuffers[i], buffers[i], imageFormat);
                images[i] = new Image(imageFormat, size, size, buffers[i],
                        ColorSpace.Linear);
                MipMapGenerator.generateMipMaps(images[i]);
            }

            final TextureCubeMap map = EnvMapUtils.makeCubeMap(images[0],
                    images[1], images[2], images[3], images[4], images[5],
                    imageFormat);
            debugEnv = map;
            job.callback.done(map);
            map.getImage().dispose();
            jobs.remove(0);
        }
    }

I guess proper handling would be to let the LightProbe finish its rendering and then attach it. Or just add it and let the user "update the maps" themselves?

Edit: Tried the latter, and got the same exception when clicking "refresh the maps". So it's something with geometries. Has anyone tried doing this through code?

[neph1]

Acceptable temp fix? I'll merge this soon unless there's further discussion.