-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Assetbrowser #506
Assetbrowser #506
Conversation
assetbrowser resizes correctly.
actually use generated preview
actually use generated preview
clean up
fix proper drop location in SceneViewer clean up
I need a break from this now... Some outstanding issues:
|
@peedeeboy Before I dig into this myself, do you know why this happens? When I do a Pics or it didn't happen! |
I came across this comment from @MeFisto94 when I was looking into the Project Asset Manager previously: /* Note: The ProjectAssetManager needs the Subproject's Project,
* because otherwise reading assets won't work (as assets is
* not in the scope of the parent project). But it still needs
* to be added to the Parent Project's Lookup
*/
/* Complicated code to find the relative path, because the
* assets subproject could be stored in a folder called "foo"
* or "bar" and we still need to locate it correctly
*/ |
Thanks, then I know it's not a bug. I'll add some 'complicated code' of my own to circumvent it :) |
I came across this as I when I looked into get the PAM to load from assets from Gradle files on the classpath I was thinking / hoping to refactor ProjectAssetManager out to an Interface / Abstract class and have AntProjectAssetManager and GradleProjectAssetManager implementations, but that turned into a rabbit hole..... Probably why nobody else had already done it :( |
I won't attempt to change anything there, just handle it on the behalf of the asset browser |
|
This is a mammoth PR, but there's no other way to do it..