Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add 5 optional libraries from com.simsilica #539

Merged
merged 1 commit into from
Oct 12, 2023
Merged

add 5 optional libraries from com.simsilica #539

merged 1 commit into from
Oct 12, 2023

Conversation

stephengold
Copy link
Member

To help steer users toward Paul Speed's libraries.

@tonihele
Copy link
Contributor

I think these will only come to the Ant projects as selectable. Is that the goal?

@stephengold
Copy link
Member Author

The goal is to make these libraries as accessible as possible to SDK users. Toward this end, if there's something we could do for Gradle and Maven users, that'd be great.

@tonihele
Copy link
Contributor

Did you try the wizard:
image

@stephengold
Copy link
Member Author

not recently

I thought this build.gradle was how 3rd-party libraries (like Wes) were bundled into the SDK for inclusion in user projects. If I was mistaken, then please close this PR without integrating.

@tonihele
Copy link
Contributor

tonihele commented Oct 1, 2023

No, it is probably fine. Im just trying to make sure what you want to do gets done. This way they go to Ant projects only, then the user has to be smart enough to figure out how to add them to their project.

The Gradle is recommended format. And there is the Gradle wizard which lets the user select all the libraries he/she/it/they/them/apache helicopter is interested in. The selection of packages is here: https://github.com/jMonkeyEngine/sdk/blob/master/jme3-templates/src/com/jme3/gde/templates/gradledesktop/options/AdditionalLibrary.java

@stephengold
Copy link
Member Author

The selection of packages is here

Good to know. Thanks!

@tonihele tonihele self-requested a review October 3, 2023 06:06
@tonihele tonihele merged commit 4971caf into jMonkeyEngine:master Oct 12, 2023
@stephengold stephengold deleted the sgold/add-simsilica branch October 13, 2023 01:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants