Skip to content

add valgrind to CI #563

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
jacobwilliams opened this issue May 28, 2024 · 3 comments · Fixed by #565
Closed

add valgrind to CI #563

jacobwilliams opened this issue May 28, 2024 · 3 comments · Fixed by #565
Labels

Comments

@jacobwilliams
Copy link
Owner

Maybe run valgrind in the CI to check for memory leaks.

@jacobwilliams
Copy link
Owner Author

jacobwilliams commented Jun 1, 2024

The following tests are showing memory leaks:

  • jf_test_12
  • jf_test_15
  • jf_test_25
  • jf_test_27
  • jf_test_37
  • jf_test_39
  • jf_test_41
  • jf_test_46
  • jf_test_50 -- fixed in c41a0c0

@jacobwilliams
Copy link
Owner Author

jacobwilliams commented Jun 1, 2024

For case 12, this is the memory leak:

my_file = json_file(root,verbose=.true.,real_format='G')

Not sure if it's the assignment or the json_file interface or some combination of both that is causing it.

Is it a real bug, or just a gfortran bug with not calling the finalizers correctly?

Assignments like my_file2 = my_file don't seem to cause memory leaks.

@jacobwilliams
Copy link
Owner Author

All of them (except 50) have this same issue.

jacobwilliams added a commit that referenced this issue Jun 1, 2024
These are causing memory leaks with gfortran
See #563
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant