Get alloc string #265
Merged
Get alloc string #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…length is the max length of any string in the array). some other minor refactoring.
…into get_alloc_string
…into get_alloc_string
…into get_alloc_string
added unit tests.
|
The new Test 25 is failing on Travis with |
jacobwilliams
commented
Mar 16, 2017
src/json_value_module.F90
Outdated
| @@ -6965,7 +6964,7 @@ subroutine get_chars_from_array(json, element, i, count) | |||
| if (.not. initialized) then | |||
| ! string length long enough to hold the longest one | |||
| allocate( character(kind=CK,len=max_len) :: vec(count) ) | |||
There was a problem hiding this comment.
This is probably causing test to fail on Travis (with the older gfortran). See #265.
Codecov Report
@@ Coverage Diff @@
## master #265 +/- ##
==========================================
- Coverage 87.08% 86.07% -1.01%
==========================================
Files 3 3
Lines 3669 3791 +122
==========================================
+ Hits 3195 3263 +68
- Misses 474 528 +54Continue to review full report at Codecov.
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added routines for getting an allocatable string vector.
Added a new
string_inforoutine.Fixes #245