Some unit tests updates

[jacobwilliams]

No description provided.

[jacobwilliams]

Now why did the new unit test fail with the cmake build? Did I mess something up?

[zbeekman]

I suspect it’s due to the new files needed for the tests… right now test inputs from the files/directory are manually enumerated in CMakeLists.txt to be copied into the appropriate location in the out-of-source CMake build—I did this because some tests overwrite files. I didn’t want one test to fail because another overwrote the files it read in and messed something up, and also I wanted to have the ability to use diff to do some regression testing. Originally only test1.json and test5.json were read in by tests. Then invalid.json and invalid2.json were added. Lines 164 - 167 ofCMakeLists.txt is where the copy takes place from the source tree to the build tree.

I’m wondering if we should have a convention to distinguish test inputs from test outputs. That way we can use file globbing to vacuum up the appropriate input files and make sure they’re copied to the build tree. At the same time if we had a convention for the test outputs, we could also automatically send them through jsonlint and compare the actual output with the anticipated output. What do you think of this idea?

[zbeekman]

If you like I may be able to find time to work up a PR against your unit-tests branch to implement some of this.

[coveralls]

Coverage remained the same at 72.88% when pulling b14f1ab on unit-tests into fde8d7d on master.